Added ignored errors patching for the build artifacts#54
Merged
Conversation
vpaiu
had a problem deploying
to
security-scanning-workflow-env
GitHub Actions
Failure
vpaiu
had a problem deploying
to
security-scanning-workflow-env
GitHub Actions
Failure
vpaiu
had a problem deploying
to
security-scanning-workflow-env
GitHub Actions
Failure
scripts/build-artifacts.sh
Outdated
| local config_file="$present_working_dir/configuration/$target.json" | ||
| if [ -f "$config_file" ]; then | ||
| local ignored_errors_path=$(jq -r '.ignoredErrors.path' "$config_file") | ||
| local ignored_errors_file="$present_working_dir/$ignored_errors_path/common-ignored-errors.json" |
Contributor
There was a problem hiding this comment.
The ignored_errors directory is specified in each target's configuration file because it allows us to define multiple ignored errors JSON files. So instead of checking for just a single file named common-ignored-errors.json, we should do a check here for all .JSON files present in the $ignored_errors_path directory and copy ignored errors from all files.
There should be 3 logical steps here:
- First step is to look for all
.jsonfiles in acommon-ignored-errorsdirectory. I know this doesn't exist right now but we'll need to create one and move thecommon-ignored-errors.jsonto that directory. - Second step is to check for all ignored files
.jsonfiles in the directory defined in target's configuration file. - And lastly we merge all of them together in one JSON and copy it over.
Contributor
Author
There was a problem hiding this comment.
Implemented the improvements mentioned above.
Tested by running the patching on built artifacts locally.
vpaiu
had a problem deploying
to
security-scanning-workflow-env
GitHub Actions
Failure
vpaiu
had a problem deploying
to
security-scanning-workflow-env
GitHub Actions
Failure
sachinh-amazon
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
scripts/build-artifacts.shscript will now patch the build artifacts with theignored-errors/common-ignored-errors.jsonfile.Testing:
Build Code Editor Targetsworkflow and checked the generated artifacts to see if the patching worked.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.